github-windows: only create archive if on master. #16017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
windows-2
branch
from
4950bcb
to
b045af1
Compare
|
We are also currently creating archives with the same name on different workers and upload them. This might create race conditions. I've added a second commit in which we only upload the artifact on one of the two workers. I hope that this will get rid of the upload errors we face regularly with these workers. |
marcfehling
force-pushed
the
windows-2
branch
from
4234e1c
to
464e265
Compare
luca-heltai
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are only uploading the library as an artifact when merged on the
masterbranch. However currently, we always create the library archive whether it is a merge commit or not.This PR suggest to build the archive only on merge commits, which should speed up the windows workers on other commits by about 5 minutes.