Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about unininitialized values in finish_integrate_fast #16022

Conversation

masterleinad
Copy link
Member

@masterleinad masterleinad commented Sep 20, 2023

Fixes #16012. Alternative to #16018.

@masterleinad
Copy link
Member Author

/rebuild

@masterleinad
Copy link
Member Author

@bergbauer FYI This fixes the warning for me.

@bergbauer
Copy link
Contributor

Does changing from n_q_points to n_q_batches here

if (n_q_points == 0 || // no evaluation points provided
also fix the warning for you? Then we would not need an additional runtime if.

@masterleinad
Copy link
Member Author

Does changing from n_q_points to n_q_batches [...] also fix the warning for you? Then we would not need an additional runtime if.

No, that's not enough. Since the stacktrace has include/deal.II/matrix_free/fe_point_evaluation.h:2548 as the last node, it seems the compiler is assuming that the function could be called from something else than FEPointEvaluation<n_components_, dim, spacedim, Number>::do_integrate().

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could go with this patch, if you don't see a change in performance @bergbauer?

@kronbichler
Copy link
Member

I went with the other PR due to the additional warning of gcc-13, let us keep this PR in mind in case we discover a similar issue in the future, thanks for the effort @masterleinad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression tester regressed 3ba99a
3 participants