Fix Assert* not ending with a semicolon #16037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Sep 22, 2023
tamiko
approved these changes
Sep 22, 2023
kronbichler
approved these changes
Sep 22, 2023
kronbichler
reviewed
Sep 22, 2023
Comment on lines
1617
to
1620
| Assert(false, ExcSingular()); | ||
| else |
There was a problem hiding this comment.
Hm, here the compiler on the serial CI complains that there is an else without an if.
There was a problem hiding this comment.
Yeah, the fixes were done according to the new version that enforces the semicolon. This is one of the shortcomings of the current implementation.
masterleinad
force-pushed
the
fix_assert_semicolon
branch
2 times, most recently
from
49e8f62
to
94fbb9d
Compare
masterleinad
force-pushed
the
fix_assert_semicolon
branch
from
94fbb9d
to
05356b1
Compare
kronbichler
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the uncontroversial part of #16026.