Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AffineConstraints::copy_from #16039

Merged
merged 2 commits into from Sep 24, 2023
Merged

fix AffineConstraints::copy_from #16039

merged 2 commits into from Sep 24, 2023

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Sep 22, 2023

We forgot to copy new fields introduced in #15789

fixes #16038

@tjhei
Copy link
Member Author

tjhei commented Sep 22, 2023

I am working on a small test case...

@tjhei tjhei mentioned this pull request Sep 22, 2023
Closed
@tjhei
fix AffineConstraints::copy_from
7ab20ed 
We forgot to copy new fields introduced in dealii#15789
bangerth
bangerth approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, doh! Thanks for fixing this!

@bangerth
Copy link
Member

I looked up the various operators. The copy operator= is deleted. The move operator= is defaulted. So for these two there is no danger. The move constructor is defaulted, so that's ok as well. But the default copy constructor has the same bug as pointed out here. I'll write a separate patch in a minute!

@bangerth
Copy link
Member

You'll need to run the indent script on the new test. Otherwise ok.

@bangerth bangerth mentioned this pull request Sep 22, 2023
Merged
peterrum
peterrum approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjhei

@tjhei
Copy link
Member Author

tjhei commented Sep 24, 2023

updated.

@tjhei
Copy link
Member Author

tjhei commented Sep 24, 2023

No sure why the test output is incorrect on the machine I ran the test...

@masterleinad masterleinad merged commit 25ed591 into dealii:master Sep 24, 2023
15 checks passed
@tjhei tjhei deleted the fix_af_copy_from branch October 3, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@bangerth bangerth bangerth approved these changes

@kronbichler kronbichler kronbichler approved these changes

@peterrum peterrum peterrum approved these changes

Assignees
No one assigned
Labels
Linear Algebra ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AffineConstraints::copy_from() misses entries
5 participants
@tjhei @bangerth @masterleinad @kronbichler @peterrum