Use gmres in step 12 #16058
Merged
Use gmres in step 12 #16058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
previously requested changes
Sep 28, 2023
Co-authored-by: Wolfgang Bangerth <bangerth@colostate.edu>
nils-schween
force-pushed
the
use-gmres-in-step-12
branch
from
2ed1e9c
to
47e3679
Compare
|
/rebuild |
kronbichler
dismissed
bangerth’s stale review
Comments were addressed. Let us merge now.
|
Thank you for the contribution @nils-schween! |
|
Thank you for the support and the advise to open this PR! I will close the related issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #15984.
Use GMRES instead of a Richardson solver in Step-12. Adapt the tutorial where necessary and fix a small error in the introduction of the tutorial.
A short comment concerning the error in the introduction: Two different scalar products are used:
The first one is for vector quantities and the second one for scalar quantities. In the discrete weak form a scalar is "dotted" with a vector. The meaning of this is unclear to me. So I replaced$(\nabla \phi_i, \mathbf{\beta} \cdot \phi_j)_T$ with $(\nabla \phi_i, \mathbf{\beta}\phi_i)_T$ . The dot product is implicit in the definition of the scalar product, which admittedly is not explicitly given in the introduction.