MGTransferMF: check compatibility of DoFHandlers #16088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
reviewed
Oct 4, 2023
| * is required to be able to use MGTransferMF and | ||
| * MGTransferMatrixFree as template argument. | ||
| * Interpolate fine-mesh field @p src to each multigrid level in | ||
| * @p dof_handler and store the result in @p dst. |
There was a problem hiding this comment.
What does dof_handler in this comment refer to? I assume you mean the one held in the class?
There was a problem hiding this comment.
I have updated the comments in interpolate_to_mg(), since they are outdated. Could you check if the notes are helpful.
include/deal.II/multigrid/mg_transfer_global_coarsening.templates.h
Outdated
Show resolved
Hide resolved
Comment on lines
+4118
to
+4136
| if (const auto t = dynamic_cast< | ||
| const MGTwoLevelTransfer<dim, | ||
| LinearAlgebra::distributed::Vector<Number>> *>( | ||
| this->transfer[this->transfer.max_level()].get())) | ||
| { | ||
| return {t->dof_handler_fine, t->mg_level_fine}; | ||
| } | ||
| else if (const auto t = dynamic_cast<const MGTwoLevelTransferNonNested< | ||
| dim, | ||
| LinearAlgebra::distributed::Vector<Number>> *>( | ||
| this->transfer[this->transfer.max_level()].get())) | ||
| { | ||
| return {t->dof_handler_fine, t->mg_level_fine}; | ||
| } | ||
| else | ||
| { | ||
| Assert(false, ExcNotImplemented()); | ||
| return {nullptr, numbers::invalid_unsigned_int}; | ||
| } |
There was a problem hiding this comment.
I think the logic in this function is harder to read than necessary because you have two different return values but four cases. Can that we re-organized?
There was a problem hiding this comment.
How do you suggest? The problem is that the base class of MGTwoLevelTransfer and MGTwoLevelTransferNonNested does not have dim as template argument so that we need to cast to the two implementations.
|
/rebuild |
kronbichler
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multigrid as preconditioner, it is possible that the outer solver and multigrid are set up with different numberings in the DoFHandlers (e.g. by using
DoFRenumbering::matrix_free_data_localityonce withMatrixFreeset up withdoubleand once withfloat). In this case, it is not enough to simply copy the vectors duringMGTransferMF::copy_to_mg(),MGTransferMF::copy_to_mg(), andMGTransferMF::interpolate_to_mg(), but one needs to permute the data. This is implemented now for global coarsening. A similar infrastructure was already available for local smoothing.