Restrict checking ArrayView validity to debug mode. #16115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
approved these changes
Oct 10, 2023
kronbichler
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
This is also a solution; I was not entirely opposed to it, but wanted to measure it before looking further into it, in most cases you are of course right that the things we do are much more expensive usually. Thanks @bangerth for the fix.
tamiko
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restricts the changes in #16112 to debug mode only. I can't really imagine it making a difference -- surely whatever we do with the contents of an
ArrayViewis more expensive than just a singleif-- but there is also no harm in only checking in debug mode.Fixes #16113.