Fix ReferenceCell::standard_vs_true_line_orientation() for simplices #16119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needed for the P3 part of #14795. |
drwells
reviewed
Oct 10, 2023
| Assert(combined_line != X, | ||
| ExcMessage( | ||
| "This function can only be called for following face-line " | ||
| "combinations: (0,0), (0,1), (0,2), (1,1), (1,2), (2,1),")); |
There was a problem hiding this comment.
I think this restriction is fine since this is not a function users would be calling.
drwells
approved these changes
Oct 10, 2023
|
Originally (#14795) I thought that we needed to consistently orient lines in the reference enumerations (i.e., vertex 0 points to vertex 1 on every face). It turns out that we had some bugs in the simplex face orientation code (#15678) which, combined with this patch, make that big patch unnecessary. Hence once this is in we should be able to add P3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very late PR of the last developer workshop :)