Added separator to Matrix::print_formatted(). #16138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
delimiter
branch
3 times, most recently
from
7e67417
to
eac798c
Compare
|
/rebuild |
bangerth
approved these changes
Oct 15, 2023
|
Can you add a changelog entry? |
marcfehling
force-pushed
the
delimiter
branch
from
eac798c
to
5159258
Compare
|
I've added a changelog entry and noticed that I forgot to adjust the |
marcfehling
force-pushed
the
delimiter
branch
from
5159258
to
0fa6ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state
print_formatted()uses spaces both to separate row entries and to denote zeros, which can be confusing.This PR suggests to specify a separator string explicitly, for example, to generate comma-separated row entries.
I cleaned up some documentation while there.