Fix compute_prefix_sum() for serial run #16139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
approved these changes
Oct 14, 2023
kronbichler
approved these changes
Oct 14, 2023
bangerth
reviewed
Oct 15, 2023
Comment on lines
+154
to
+155
| if (comm == MPI_COMM_SELF) | ||
| return {0, value}; // serial triangulation |
There was a problem hiding this comment.
I don't think this is the right tests. You want to check whether the communicator has one process attached. It doesn't have to be MPI_COMM_SELF -- it could be MPI_COMM_WORLD or a sub-communicator, as long as it's only got one process. I think it would be better to test Utilities::MPI::n_mpi_processes(comm)==1 here.
Separately, the comment is not useful. There is no triangulation available in this function.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.