Add AffineConstraints::constrain_dof_to_zero(). #16163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
approved these changes
Oct 21, 2023
drwells
approved these changes
Oct 23, 2023
|
This is much easier to read - lets do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm generally not a friend of introducing more member functions for convenience, but think that this may be an exception (that I'm happy to see debated): In a previous patch (#16103), I added
AffineConstraints::add_constraint()that adds an entire constraint at once. But, in a substantial number of places, we call this asconstraints.add_constraint(dof_index, {}, 0.), which means to constrain the DoF to zero, without dependencies. This is not wrong, and documented as saying exactly that, but it isn't entirely obvious to read. So this patch introducesAffineConstraints::constrain_to_zero(dof_index), which I think is easier to read. The patch then also converts all of the places in the library and the examples to call this function. The last commit also replaces some calls to our old API in the test suite by the new function.Happy to debate the wisdom of the proposal :-)
In reference to #15375.