Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KINSOL: option to select QR orthogonalization strategy #16239

Merged
merged 1 commit into from Dec 21, 2023

Conversation

sebproell
Copy link
Contributor

This option is available from SUNDIALS 6.0.0 onwards. If an older version is used, we throw an error if a user asks for an orthogonalization strategy different from the default.

include/deal.II/sundials/kinsol.h Outdated Show resolved Hide resolved
source/sundials/kinsol.cc Outdated Show resolved Hide resolved
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just two minor textual issues.

Is it possible to clone one of the tests to check these features? It would be interesting to see how this affects the number of iterations.

include/deal.II/sundials/kinsol.h Outdated Show resolved Hide resolved
include/deal.II/sundials/kinsol.h Outdated Show resolved Hide resolved
include/deal.II/sundials/kinsol.h Outdated Show resolved Hide resolved
include/deal.II/sundials/kinsol.h Outdated Show resolved Hide resolved
include/deal.II/sundials/kinsol.h Outdated Show resolved Hide resolved
source/sundials/kinsol.cc Show resolved Hide resolved
This option is available since SUNDIALS 6.0.0.
@sebproell
Copy link
Contributor Author

sebproell commented Nov 4, 2023

Thanks for the reviews! Regarding a test: the strategy only makes sense in a parallel setting and I first need to teach our N_Vector a few more efficient operations. The current state works, but technically we are not working on multi-vectors. I would write a test with all of these features on a larger example. The current FP iteration example just has three vector elements so there is not much too parallelize if I copy this one.

@bangerth
Copy link
Member

bangerth commented Nov 5, 2023

That works, but it's worth pointing out that tests do not have to show useful use of features. Just the fact that they run through specific lines of code is often an important feature of a test.

@sebproell
Copy link
Contributor Author

@bangerth Do you want me to change anything more here?

@kronbichler
Copy link
Member

@bangerth can we merge this PR for now and add the test later? If I understand @sebproell correctly, he is going to work on modifications where the feature would be tested?

@sebproell
Copy link
Contributor Author

Yes, I will continue working on this soon.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to have tests for this, but the code itself is ok.

@bangerth bangerth merged commit b0ccdbc into dealii:master Dec 21, 2023
15 checks passed
@sebproell sebproell deleted the kinsol-ortho branch February 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants