New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KINSOL: option to select QR orthogonalization strategy #16239
Conversation
819ed87
to
db4871f
Compare
db4871f
to
d2c52b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just two minor textual issues.
Is it possible to clone one of the tests to check these features? It would be interesting to see how this affects the number of iterations.
This option is available since SUNDIALS 6.0.0.
d2c52b4
to
2b9ad77
Compare
Thanks for the reviews! Regarding a test: the strategy only makes sense in a parallel setting and I first need to teach our |
That works, but it's worth pointing out that tests do not have to show useful use of features. Just the fact that they run through specific lines of code is often an important feature of a test. |
@bangerth Do you want me to change anything more here? |
@bangerth can we merge this PR for now and add the test later? If I understand @sebproell correctly, he is going to work on modifications where the feature would be tested? |
Yes, I will continue working on this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like to have tests for this, but the code itself is ok.
This option is available from SUNDIALS 6.0.0 onwards. If an older version is used, we throw an error if a user asks for an orthogonalization strategy different from the default.