Ensure that Lazy functions are called with a callable argument. #16267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
commented
Nov 14, 2023
| @@ -136,7 +138,8 @@ class Lazy | |||
| */ | |||
| template <typename Callable> | |||
| void | |||
| ensure_initialized(const Callable &creator) const; | |||
| ensure_initialized(const Callable &creator) const | |||
| DEAL_II_CXX20_REQUIRES((std::is_invocable_r_v<T, Callable>)); | |||
There was a problem hiding this comment.
I will note that there is a std::invocable concept: https://en.cppreference.com/w/cpp/concepts/invocable The problem is that there is no concept like std::invocable_r that also checks the return type. One could do this with std::invoke_result (https://en.cppreference.com/w/cpp/types/result_of), but that's no simpler than this here. In the end, the thing in a requires clause just has to be a boolean expression. It doesn't have to be a concept.
drwells
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #16182 .