Fix vertex orientations in torus mesh #16287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Nov 22, 2023
|
|
||
|
|
||
| // Test GridGenerator::torus, which used to run into an assertion with p4est | ||
| // due to bad orientations before 2023 |
There was a problem hiding this comment.
Could you add the issue number?
|
@kronbichler There is a failing test:
|
kronbichler
force-pushed
the
fix_torus
branch
from
9c71769
to
7ec2ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16272 - I think the basic test case by @peterrum is enough if we look at the mesh statistics (also for p4est versions that do not include the assertion, I see that p4est 2.8 would throw).
Note that I had to adjust one test case where the order of vertices in the torus would matter.