Make FEValuesViews::* objects movable. #16298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
Nov 26, 2023
masterleinad
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out the hard way (see #16297) that the
FEValuesViews::*classes are not movable even though the move constructors and move assignment operators are marked with=default. That's because these classes haveconstmember variables that mean that=defaultequals=delete-- not what one thinks about at first.I want to make these classes movable because then we can lazily construct them with
Lazy<T>, see #16182. I have a patch ready for this, but it relies on #16295. The changes here can stand on their own, however.