Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistaken std::move assignment. #16335

Merged
merged 1 commit into from Dec 9, 2023
Merged

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented Dec 8, 2023

This fixes #16332. The issue here is that the assignment

temperature_solution     = tmp[0];

doesn't just copy the rhs to the lhs, but because the lhs is a ghosted vector and the rhs is not, it also imports elements. We do not get these semantics if we make this into a move assignment

temperature_solution     = std::move(tmp[0]);

as I had mistakenly done in #15438.

@marcfehling marcfehling merged commit 8a9cd37 into dealii:master Dec 9, 2023
15 checks passed
@bangerth bangerth deleted the 32-2 branch December 10, 2023 16:42
@drwells drwells added the Bug label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

step-32 triggers an assertion.
4 participants