Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::optional instead of a hand-rolled version of it. #16350

Merged
merged 1 commit into from Dec 15, 2023
Merged

Use std::optional instead of a hand-rolled version of it. #16350

merged 1 commit into from Dec 15, 2023

Conversation

bangerth
Copy link
Member

In reference to #16346.

kronbichler
kronbichler approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, although I admit that writing cell.value()-> instead of cell-> at the places of use is a bit annoying. But we can't have the cake and eat it, too.

@kronbichler kronbichler merged commit ad01b96 into dealii:master Dec 15, 2023
15 checks passed
@bangerth bangerth deleted the optional branch December 15, 2023 08:24
@bangerth
Copy link
Member Author

True :-) I've got a couple of follow-ups that hopefully make it all a bit simpler still.

@bangerth bangerth mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kronbichler kronbichler kronbichler approved these changes

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
Finite Element ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bangerth @kronbichler @marcfehling