Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FPE::real_point() to FPE::quadrature_point() #16423

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Rename FPE::real_point() to FPE::quadrature_point() #16423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/news/changes/incompatibilities/20240107Munch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Removed: The function FEPointEvaluation::real_point() has been
renamed to FEPointEvaluation::quadrature_point(). The old function
has been deprecated.
<br>
(Peter Munch, 2024/01/01)
22 changes: 21 additions & 1 deletion include/deal.II/matrix_free/fe_point_evaluation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,12 +845,21 @@ class FEPointEvaluationBase
Number
JxW(const unsigned int point_index) const;

/**
* Return the position in real coordinates of the given point index among
* the points passed to reinit().
*
* @deprecated Use the function quadrature_point() instead.
*/
DEAL_II_DEPRECATED_EARLY Point<spacedim, Number>
real_point(const unsigned int point_index) const;

/**
* Return the position in real coordinates of the given point index among
* the points passed to reinit().
*/
Point<spacedim, Number>
real_point(const unsigned int point_index) const;
quadrature_point(const unsigned int point_index) const;

/**
* Return the position in unit/reference coordinates of the given point
Expand Down Expand Up @@ -2245,6 +2254,17 @@ template <int n_components_, int dim, int spacedim, typename Number>
inline Point<spacedim, Number>
FEPointEvaluationBase<n_components_, dim, spacedim, Number>::real_point(
const unsigned int point_index) const
{
return quadrature_point(point_index);
;
}



template <int n_components_, int dim, int spacedim, typename Number>
inline Point<spacedim, Number>
FEPointEvaluationBase<n_components_, dim, spacedim, Number>::quadrature_point(
const unsigned int point_index) const
{
AssertIndexRange(point_index, n_q_points);
Assert(real_point_ptr != nullptr,
Expand Down
4 changes: 2 additions & 2 deletions tests/matrix_free/point_evaluation_12.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// ------------------------------------------------------------------------


// check FEPointEvaluation::real_point(), FEPointEvaluation::unit_point(),
// check FEPointEvaluation::quadrature_point(), FEPointEvaluation::unit_point(),
// FEPointEvaluation::jacobian(), FEPointEvaluation::inverse_jacobian(),
// FEPointEvaluation::get_unit_gradient().

Expand Down Expand Up @@ -97,7 +97,7 @@ test(const unsigned int degree)
deallog << "unit point " << unit_points[i] << std::endl
<< "unit point via evaluator: " << evaluator.unit_point(i)
<< std::endl
<< "real point: " << evaluator.real_point(i) << std::endl
<< "real point: " << evaluator.quadrature_point(i) << std::endl
<< "jacobian: " << Tensor<2, dim>(evaluator.jacobian(i))
<< std::endl
<< "inverse jacobian: "
Expand Down