DofTools: add missing codimension-one instantiation #16494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Jan 18, 2024
|
/rebuild |
marcfehling
reviewed
Jan 18, 2024
| @@ -257,15 +257,17 @@ for (deal_II_dimension : DIMENSIONS) | |||
| } | |||
|
|
|||
|
|
|||
| for (deal_II_dimension : DIMENSIONS) | |||
| for (deal_II_dimension, deal_II_space_dimension : DIMENSIONS) | |||
There was a problem hiding this comment.
Suggested change
| for (deal_II_dimension, deal_II_space_dimension : DIMENSIONS) | |
| for (deal_II_dimension : DIMENSIONS; deal_II_space_dimension : SPACE_DIMENSIONS) |
We have split dim and spacedim into two separate template argument lists in other occassions.
See also
dealii/cmake/config/template-arguments.in
Line 254 in 20d2176
dealii/source/grid/tria.inst.in
Line 18 in a65d7b4
There was a problem hiding this comment.
Hmm, we wrote (deal_II_dimension, deal_II_space_dimension : DIMENSIONS) also in other parts of the library. Maybe it's better to discuss it in a separate PR. I will prepare one.
There was a problem hiding this comment.
@marcfehling Yes, let's fix that up in a separate PR so that we catch all occurences.
marcfehling
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #16493