Move matrix free classes from CUDAWrappers namespace to Portable namespace #16497
Conversation
Rombur
force-pushed
the
rename_cudawrappers
branch
from
bfdcce9
to
8c8ff18
Compare
| FEEvaluation<dim, fe_degree, n_q_points_1d, n_components_, Number>:: | ||
| n_q_points; | ||
| #endif | ||
| using namespace Portable; |
There was a problem hiding this comment.
That's clever. Is there also a way to effectively deprecate the whole CUDAWrappers namespace?
There was a problem hiding this comment.
The problem is that nvcc doesn't like when I deprecate the namespace. With the others compilers I can do
namespace DEAL_II_EARLY_DEPRECATION CUDAWrappers and it works like expected. We could only emit the deprecation warning when people use a compiler other than nvcc but I would expect that almost everybody that uses this class also uses nvcc.
There was a problem hiding this comment.
What does "nvcc doesn't like when I deprecate the namespace" exactly mean?
Is the attribute just not recognized and the compiler warns about that (like in https://godbolt.org/z/Mf3444sP9 which only recognizes the attribute from nvcc 11.1.0 on) or is there a different issue?
There was a problem hiding this comment.
Yes, the compiler complains that attribute is not recognized.
There was a problem hiding this comment.
We should just do a version check then since it seems to work from nvcc 11.1.0 on.
There was a problem hiding this comment.
I don't think that the issue is due to nvcc version. The CI fails with nvcc 11.8. I think that the problem is the underlying gcc compiler. The CI uses gcc 9 which had a bug when using [[deprecated]] with a namespace (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79817)
Rombur
force-pushed
the
rename_cudawrappers
branch
from
8c8ff18
to
dde0afe
Compare
Rombur
force-pushed
the
rename_cudawrappers
branch
from
dde0afe
to
e12365b
Compare
Rombur
force-pushed
the
rename_cudawrappers
branch
2 times, most recently
from
60b14c7
to
e37a9cc
Compare
Rombur
force-pushed
the
rename_cudawrappers
branch
from
e37a9cc
to
3bdb6d8
Compare
|
/rebuild |
|
Unless someone has an objection, I will merge this tomorrow. |
This is a proposal to move the matrix free classes out of the CUDAWrappers namespace to a new Portable namespace. The current namespace doesn't make sense anymore because the current code works fine on AMD GPUs. I am open to a different name for the new namespace if someone as a better idea. There is the issue on how to deprecated the old namespace. nvcc seems to have an issue with the deprecated attribute for a namespace.