Testsuite: use ./serial subdirectory
#16551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
changed the title
./serial subdirectory
kronbichler
approved these changes
Jan 27, 2024
blaisb
approved these changes
Jan 27, 2024
blaisb
added a commit
to chaos-polymtl/lethe
that referenced
this pull request
Jan 29, 2024
Description of the problem Deal.II introduced a serial folder for serial tests. This is a very good idea because it introduces uniformity when we have serial and mpitests. However, this is not maintainable if we have deal.II 9.5 and 9.6 working. The PR is this one: Testsuite: use ./serial subdirectory dealii/dealii#16551 Description of the solution For the time being, all tests that have files are given the label mpirun=1 before their output. As such, their behavior is identical between 9.5 and 9.6. This ensures that the tests are working correctly. Once we migrate away from deal.II 9.5 (this summer) this idea could be reverted to use the regular serial folders. This is an adequate fix for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @peterrum