Make a deep-copy of the Tpetra::Vector in the assignment operator. #16558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinnewig
force-pushed
the
copy-assignment
branch
from
6cd25b0
to
f22c82d
Compare
masterleinad
previously approved these changes
Jan 29, 2024
|
/rebuild |
kronbichler
approved these changes
Jan 29, 2024
bangerth
previously requested changes
Jan 29, 2024
kinnewig
force-pushed
the
copy-assignment
branch
from
d9a9b6f
to
810153e
Compare
kronbichler
approved these changes
Jan 30, 2024
|
Nice, that was a good suggestion @masterleinad! |
Comment on lines
+293
to
+300
| # if DEAL_II_TRILINOS_VERSION_GTE(13, 2, 0) | ||
| auto source_vector_2d = | ||
| V.vector->template getLocalView<Kokkos::HostSpace>( | ||
| Tpetra::Access::ReadOnly); | ||
| # else | ||
| auto source_vector_2d = | ||
| V.vector->template getLocalView<Kokkos::HostSpace>(); | ||
| # endif |
There was a problem hiding this comment.
Since we are now using deep_copy, is there a good reason to extract the host view instead of the device view? In case of a device memory space (which we don't support yet), the approach here seems to make unnecessary copies between host and device since all operations are explicitly done on the host.
There was a problem hiding this comment.
Let's just get this in and we can look at this somewhere else.
masterleinad
approved these changes
Jan 30, 2024
bangerth
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of the PR #16545.
In the assignment operator, we must perform a deep-copy of the vector instead of a shallow copy.
This should fix the assignment operator.