Template TrilinosWrappers::Vector on memory space #16565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jan 30, 2024
Comment on lines
128
to
129
| template <typename Number> | ||
| template <typename Number, typename MemorySpace> | ||
| class VectorReference |
There was a problem hiding this comment.
Perhaps default the argument here as well? It probably doesn't matter given that people will unlikely create objects of this type by hand, but it won't hurt.
|
Looks good and makes sense! |
kronbichler
approved these changes
Jan 31, 2024
|
Thank you! I was planning on doing that on my own, but I hadn't found the time yet. |
|
I just checked it out and ran a few more tests, everything seems to work fine! |
|
Thank you, @masterleinad for making the change, and @kinnewig for confirming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with
TpetraWarappers::SparseMatrix,TpetraWrappes::SparsityPattern, andLinearAlgebra::distributed::Vector, we should also templateTpetraWrappers::Vectoron the memory space being used.In particular, we need matching memory spaces for the sparse matrix-vector product anyway.
This also avoids allocating a second
Viewwhen compiling with a GPU backend but only using host capabilities for these classes.