Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for deal.II solvers with TpetraWrappers classes #16625

Merged
merged 3 commits into from Feb 11, 2024

Conversation

jpthiele
Copy link
Contributor

This ports the tests for Trilinos/Epetra to the new LinearAlgebra::TpetraWrappers classes.

@jpthiele jpthiele mentioned this pull request Feb 10, 2024
4 tasks
@bangerth
Copy link
Member

/rebuild

@bangerth
Copy link
Member

Are these tests a subset of the ones in #16611 ?

@jpthiele
Copy link
Contributor Author

Are these tests a subset of the ones in #16611 ?

Yes they are.

The f = 1.; line needed changing as that now throws an exception like in the LA::distributed::Vector when not seeting f = 0.;.

The output needed the correct mangled class name and I also updated the latter copyright year and removed the include for the vector header as that is one of the first line in the matrix header.

@bangerth
Copy link
Member

OK. What I hear you say is that we don't lose anything if I remove the tests named identically here and in #16611 from #16611?

@jpthiele
Copy link
Contributor Author

Exactly, and then we are at 77 (after rebase)

@bangerth bangerth merged commit dc1ef7b into dealii:master Feb 11, 2024
15 checks passed
@jpthiele jpthiele deleted the tpetra_test_dealii_solvers branch February 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants