ConsensusAlgorithmsPayload: switch internal data type #16631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
changed the title
kronbichler
reviewed
Feb 12, 2024
| @@ -638,7 +639,7 @@ namespace Utilities | |||
| send_requests.push_back(MPI_Request()); | |||
| const int ierr = MPI_Isend(send_data[i].data(), | |||
| send_data[i].size(), | |||
| MPI_UNSIGNED, | |||
| MPI_UNSIGNED_LONG, | |||
There was a problem hiding this comment.
Can you please adjust this type such that it both works with 32 and 64 bit integers (note the type of types::global_dof_index?
peterrum
force-pushed
the
mpi_compute_index_owner_internal_global_dof_index
branch
from
3d53242
to
6eec835
Compare
peterrum
changed the title
kronbichler
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
I checked the other occurrences of 32/64 bit indices in this setup and could not find other problematic places. This does obviously not ensure that I'm not missing some place, but with @marcfehling's success I am confident that we fixed the imminent problem.
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.