GridTools::compute_active_cell_halo_layer() for periodic meshes #16632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Feb 12, 2024
|
Can we adapt some of our tests with shared triangulation to periodic boundary conditions, so we keep a record of correctness? |
peterrum
force-pushed
the
compute_active_cell_halo_layer_pbc
branch
from
55ab082
to
a1055cd
Compare
peterrum
commented
Feb 12, 2024
There was a problem hiding this comment.
Can we adapt some of our tests with shared triangulation to periodic boundary conditions, so we keep a record of correctness?
I have added a test. However, it turned out that the generalization of the function was not completely enough to make p:s:T with artificial cells working for PBC. I needed to add an additional if-statement. See below.
Comment on lines
+3243
to
+3257
| // In the case of shared Trinagulation with artificial cells all | ||
| // cells have valid DoF indices, i.e., the check above does not work. | ||
| if (const auto tria = dynamic_cast< | ||
| const parallel::shared::Triangulation<dim, spacedim> *>( | ||
| &face_1->get_triangulation())) | ||
| if (tria->with_artificial_cells() && | ||
| (affine_constraints.get_local_lines().size() != 0)) | ||
| for (unsigned int i = 0; i < dofs_per_face; ++i) | ||
| if ((affine_constraints.get_local_lines().is_element(dofs_1[i]) == | ||
| false) || | ||
| (affine_constraints.get_local_lines().is_element(dofs_2[i]) == | ||
| false)) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
These lines
dealii/source/dofs/dof_tools_constraints.cc
Lines 3236 to 3241 in a1055cd
I added an additional check for p:s:T.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is used internally used by
p:s:T)