New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info for TPLs to testsuite doc. #16646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the text would make more sense in the "Restricting tests to feature configurations" subsection.
f2e0687
to
6c29b1b
Compare
You are right. I moved it there. |
Does this fix #16643? |
doc/developers/testsuite.html
Outdated
@@ -479,6 +479,11 @@ <h3>Restricting tests to feature configurations</h3> | |||
category/test.with_zlib=off.output | |||
</pre> | |||
These tests will only be set up if the specified feature was configured. | |||
<p><b>Note:</b> For CMake variables switching subpackages of third party libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the term "switching" confusing here. Perhaps use "For CMake variables indicating whether sub-packages of third party libraries were detected, like ..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds better, I changed it to that.
Yes the CMake works fine, you just have to know that while |
6c29b1b
to
b9f376b
Compare
Fixes #16643.
This adds a short paragraph describing how to limit the test run
to a more specific third party library configuration like
DEAL_II_TRILINOS_WITH_BELOS
such that a test can be run if the optional dependency is fulfilled.