Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info for TPLs to testsuite doc. #16646

Merged
merged 1 commit into from Feb 14, 2024

Conversation

jpthiele
Copy link
Contributor

@jpthiele jpthiele commented Feb 14, 2024

Fixes #16643.
This adds a short paragraph describing how to limit the test run
to a more specific third party library configuration like DEAL_II_TRILINOS_WITH_BELOS
such that a test can be run if the optional dependency is fulfilled.

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text would make more sense in the "Restricting tests to feature configurations" subsection.

@jpthiele
Copy link
Contributor Author

You are right. I moved it there.

@drwells
Copy link
Member

drwells commented Feb 14, 2024

Does this fix #16643?

@@ -479,6 +479,11 @@ <h3>Restricting tests to feature configurations</h3>
category/test.with_zlib=off.output
</pre>
These tests will only be set up if the specified feature was configured.
<p><b>Note:</b> For CMake variables switching subpackages of third party libraries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the term "switching" confusing here. Perhaps use "For CMake variables indicating whether sub-packages of third party libraries were detected, like ..."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds better, I changed it to that.

@jpthiele
Copy link
Contributor Author

Does this fix #16643?

Yes the CMake works fine, you just have to know that while with_trilinos=on maps to DEAL_II_WITH_TRILINOS=ON
trilinos_with_amesos2=on does not map to DEAL_II_TRILINOS_WITH_AMESOS2 and you have to use with_trilinos_with_amesos2=on as the with_ prefix gets regexed away and the rest is appended as uppercase to both
DEAL_II_ and DEAL_II_WITH_.

@masterleinad masterleinad changed the title Add info for TPLs to testsuite doc. Fixes #16643 Add info for TPLs to testsuite doc. Feb 14, 2024
@bangerth bangerth merged commit d0de226 into dealii:master Feb 14, 2024
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test pickup for DEAL_II_TRILINOS_*
4 participants