Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the remaining SUNDIALS 7 output variants. #16651

Merged
merged 1 commit into from Feb 19, 2024
Merged

Add the remaining SUNDIALS 7 output variants. #16651

merged 1 commit into from Feb 19, 2024

Conversation

bangerth
Copy link
Member

This is the companion to #16650. ARKODE has apparently gotten better and now uses fewer function evaluations. Since we output something for every function evaluation, this shows up in the output files. In the specific case of arkode_11, we throw a recoverable error every time we solve a linear system, and in past versions SUNDIALS just gave up in view of this madness, specifically after 62 times of being told "I can't do this". It now has more patience, and the 59 failures it gets handed no longer deter it.

The diffs are as follows:

arkode_08.output
*** arkode_08.output    2024-02-14 14:55:37.281192563 -0700
--- arkode_08.output.sundials7  2024-02-14 17:36:29.178932512 -0700
***************
*** 2,17 ****
  DEAL::0.00000 1.00000 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:cg::Starting value 2.23607
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.00869741
  DEAL:cg::Convergence step 1 value 0.00000
--- 2,13 ----
  DEAL::0.00000 1.00000 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.00869741
  DEAL:cg::Convergence step 1 value 0.00000
***************
*** 76,91 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:cg::Starting value 2.23607
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.235321
  DEAL:cg::Convergence step 1 value 0.00000
--- 72,83 ----
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.235321
  DEAL:cg::Convergence step 1 value 0.00000
***************
*** 150,156 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
--- 142,151 ----
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
! DEAL:cg:mass_preconditioner_solve::applied
! DEAL:cg::Convergence step 1 value 0.00000
! DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
***************
*** 164,176 ****
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL::0.200000 1.30000 0.300000
  DEAL:mass_preconditioner_setup::applied
- DEAL:cg::Starting value 0.707107
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
- DEAL:cg::Starting value 2.23607
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
- DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.625723
  DEAL:cg::Convergence step 1 value 1.11022e-16
  DEAL:cg::Starting value 0.707107
--- 159,164 ----
***************
*** 234,242 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
--- 222,233 ----
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
+ DEAL:cg::Starting value 0.707107
+ DEAL:cg:mass_preconditioner_solve::applied
+ DEAL:cg::Convergence step 1 value 7.85046e-17
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
***************
*** 272,279 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL::0.900000 2.35000 1.35000
- DEAL:mass_preconditioner_setup::applied
- DEAL:cg::Starting value 2.12132
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
  DEAL::1.00000 2.50000 1.50000
--- 263,266 ----
arkode_10.output
*** arkode_10.output    2024-02-14 14:55:37.285192563 -0700
--- arkode_10.output.sundials7  2024-02-14 17:37:29.097930898 -0700
***************
*** 2,17 ****
  DEAL::0.00000 1.00000 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:cg::Starting value 2.23607
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving linearized system.
  DEAL:cg::Starting value 0.707107
--- 2,13 ----
  DEAL::0.00000 1.00000 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving linearized system.
  DEAL:cg::Starting value 0.707107
***************
*** 69,84 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
- DEAL:cg::Starting value 2.23607
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving linearized system.
  DEAL:cg::Starting value 0.707107
--- 65,76 ----
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving linearized system.
  DEAL:cg::Starting value 0.707107
***************
*** 136,144 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
--- 128,139 ----
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
+ DEAL:cg::Starting value 0.707107
+ DEAL:cg:mass_preconditioner_solve::applied
+ DEAL:cg::Convergence step 1 value 7.85046e-17
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
***************
*** 150,155 ****
--- 145,151 ----
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL::0.200000 1.30000 0.300000
  DEAL:mass_preconditioner_setup::applied
+ DEAL::Reporting recoverable failure when solving linearized system.
  DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 7.85046e-17
***************
*** 205,219 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
- DEAL::Reporting recoverable failure when solving linearized system.
- DEAL:cg::Starting value 0.707107
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 7.85046e-17
  DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
! DEAL:mass_preconditioner_setup::applied
! DEAL:cg::Starting value 2.12132
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
--- 201,210 ----
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 2.23607
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
! DEAL:cg::Starting value 0.707107
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL:mass_preconditioner_setup::applied
***************
*** 251,258 ****
  DEAL:cg:mass_preconditioner_solve::applied
  DEAL:cg::Convergence step 1 value 0.00000
  DEAL::0.900000 2.35000 1.35000
- DEAL:mass_preconditioner_setup::applied
- DEAL:cg::Starting value 2.12132
- DEAL:cg:mass_preconditioner_solve::applied
- DEAL:cg::Convergence step 1 value 0.00000
  DEAL::1.00000 2.50000 1.50000
--- 242,245 ----
arkode_11.output
*** arkode_11.output    2024-02-14 14:55:37.287192563 -0700
--- arkode_11.output.sundials7  2024-02-14 17:38:41.841928938 -0700
***************
*** 3,10 ****
  DEAL:mass_preconditioner_setup::applied
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
- DEAL:mass_preconditioner_setup::applied
- DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.00144957
--- 3,8 ----
***************
*** 43,50 ****
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
- DEAL:mass_preconditioner_setup::applied
- DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.0392202
--- 41,46 ----
***************
*** 83,88 ****
--- 79,85 ----
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
+ DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::0.100000 1.00000 0.00000
***************
*** 90,98 ****
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::0.200000 1.00000 0.00000
  DEAL:mass_preconditioner_setup::applied
- DEAL::Reporting recoverable failure when solving with the mass matrix.
- DEAL::Reporting recoverable failure when solving with the mass matrix.
- DEAL:mass_preconditioner_setup::applied
  DEAL:cg::Starting value 0.104287
  DEAL:cg::Convergence step 1 value 1.96262e-17
  DEAL::Reporting recoverable failure when solving with the mass matrix.
--- 87,92 ----
***************
*** 129,134 ****
--- 123,129 ----
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
+ DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::0.300000 1.00000 0.00000
***************
*** 150,170 ****
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::0.900000 1.00000 0.00000
! DEAL:mass_preconditioner_setup::applied
! DEAL::Reporting recoverable failure when solving with the mass matrix.
! DEAL::Caught exception:
! DEAL::
! --------------------------------------------------------
! An error occurred in line <0> of file <> in function
!     
! The violated condition was: 
!     
! Additional information: 
!     A user call-back function encountered a recoverable error, but the
!     underlying library that called the call-back did not manage to recover
!     from the error and aborted its operation.
!     
!     See the glossary entry on user call-back functions for more
!     information.
! --------------------------------------------------------
! 
--- 145,148 ----
  DEAL:mass_preconditioner_setup::applied
  DEAL::Reporting recoverable failure when solving with the mass matrix.
  DEAL::0.900000 1.00000 0.00000
! DEAL::1.00000 1.00000 0.00000

I am satisfied that these are all harmless differences.

@bangerth
Copy link
Member Author

Ping?

@masterleinad masterleinad merged commit cc045c7 into dealii:master Feb 19, 2024
16 checks passed
@bangerth bangerth deleted the sundials7-2 branch February 19, 2024 19:52
@bangerth bangerth mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bangerth @masterleinad