Use size_type as return type of SparseMatrix::m(). #16670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes these functions consistent with what we have in the Epetra wrappers, and (that was my original motivation) avoids warnings in the block matrix class about comparing integers of different sizes/signedness.
Conceptually, it makes sense to use
size_type
for these functions.size_type
is defined asSo it is unsigned, which is exactly what these functions should return.
(I will note as an aside that different parts of the Tpetra wrappers define their own
size_type
types, and some of these are signed:This is perhaps not great design. I'll open an issue about this.)