contrib/utilities/update-copyright.sh: several improvements #16689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
force-pushed
the
update_copyright_script
branch
from
566b423
to
19e016c
Compare
tamiko
force-pushed
the
update_copyright_script
branch
from
19e016c
to
d034789
Compare
tamiko
force-pushed
the
update_copyright_script
branch
4 times, most recently
from
31319d3
to
22a3452
Compare
tamiko
force-pushed
the
update_copyright_script
branch
from
22a3452
to
8f582bf
Compare
- make lookup of last modification year more robust - add a --pedantic mode that greps the first year a file was modified from git log - restructure processing into a separate bash function and add parallel processing structure - run script on all files of the repository
tamiko
force-pushed
the
update_copyright_script
branch
from
8f582bf
to
add8119
Compare
|
@masterleinad I will run this script tomorrow on the header branch and verify that this indeed fixes all date ranges. |
|
@tjhei ping |
tjhei
approved these changes
Feb 27, 2024
bangerth
reviewed
Feb 27, 2024
| # full history: | ||
| # | ||
|
|
||
| [ -z "$last_year" ] && last_year=`git log --date=short --format="format:%cd %s" ${file} | \ |
There was a problem hiding this comment.
Out of curiosity, why didn't you just write this as if test -z "$last_year" ; then ...?
There was a problem hiding this comment.
This is really purely a stylistic choice:
testand[are the same shell built-in. And[ -z ... ]looks better thantest -z .... I should have probably used the extended test pattern[[ ... ]]consistently...- I tend to use the
[[ ... ]] && VARIABLE="..."a lot for simple conditional variable assignments. That's somewhat a bash coding style coming from Gentoo ebuilds. But yes, we could have used anifstatement as well.
There was a problem hiding this comment.
I see. It's perhaps a bit harder to read, but I'm ok with the stylistic choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #16686 to facilitate easier review.