Colorize hyper rectangle with simplices #16713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Mar 5, 2024
bangerth
requested changes
Mar 6, 2024
source/grid/grid_generator.cc
Outdated
Comment on lines
8795
to
8802
| double epsilon = 10; | ||
| for (unsigned int i = 0; i < dim; ++i) | ||
| epsilon = std::min(epsilon, | ||
| 0.01 * (std::abs(p2[i] - p1[i]) / repetitions[i])); |
There was a problem hiding this comment.
This is not the right way to approach this. p2[i] - p1[i] is a quantity that depends on the magnitude of the points chosen as inputs, so it has physical units. But eps=10 does not. You need to start with an eps that has the right order of magnitude. Alternatively, you could start with eps=infinity, i.e., eps=std::numeric_limits<double>::max().
There was a problem hiding this comment.
I agree. I'll use the numeric limits and update subdivided_hyper_rectangle() (without simplicies), too.
nmuch
force-pushed
the
colorize-hyper-rectangle-with-simplices
branch
from
4cc6a55
to
ab2c3d5
Compare
kronbichler
approved these changes
Mar 6, 2024
masterleinad
approved these changes
Mar 6, 2024
bangerth
approved these changes
Mar 6, 2024
|
This looks right now. Thank you! It would be nice to have a test that checks this. Do you know how to clone existing tests and add those? |
nmuch
force-pushed
the
colorize-hyper-rectangle-with-simplices
branch
from
5280e54
to
13bd970
Compare
kronbichler
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.