Fix Tpetra SparseMatrix::add(). #16731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tpetra interfaces apparently have no way of adding one matrix to another in-place. Instead, they have this function that returns the sum of the two: https://docs.trilinos.org/dev/packages/tpetra/doc/html/classTpetra_1_1CrsMatrix.html#a3ee27c311324dcc76e91dac9084011e1 Inconveniently, it requires some casting of pointers with its return value.
In the current implementation, we call this function but forget about its return value, presumably because the corresponding Epetra function did the addition in-place. This patch fixes this for the Tpetra wrappers. This patch is necessary to successfully pass the tests that I'm adding with the next PR, so I didn't add specific tests for this function.