Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenCascade 7.8.0 #16738

Merged
merged 2 commits into from Mar 9, 2024
Merged

Add support for OpenCascade 7.8.0 #16738

merged 2 commits into from Mar 9, 2024

Conversation

thierry-FreeBSD
Copy link
Contributor

@thierry-FreeBSD thierry-FreeBSD commented Mar 8, 2024 •
edited by marcfehling

This adds support for OCCT 7.8.0 and resolves #16737 .

tamiko
tamiko requested changes Mar 9, 2024
View reviewed changes
Copy link
Member

@tamiko tamiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! I have a minor refactoring request.

cmake/modules/FindDEAL_II_OPENCASCADE.cmake Show resolved Hide resolved
@thierry-FreeBSD
Copy link
Contributor Author

Refactorization done at a56dbea

@tamiko
Copy link
Member

tamiko commented Mar 9, 2024

/rebuild

@tamiko tamiko merged commit aca4f98 into dealii:master Mar 9, 2024
15 of 16 checks passed
@tamiko tamiko mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamiko tamiko tamiko approved these changes

Assignees
No one assigned
Labels
Build system External libraries ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deal.II does not support OpenCascade 7.8.0
3 participants
@thierry-FreeBSD @tamiko @marcfehling