Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor product tests: Fix include file #16740

Merged
merged 1 commit into from Mar 9, 2024

Conversation

kronbichler
Copy link
Member

This fixes #16739 - with parts of the functionality now moved to another header file, we need to include that new header file now. It might be an option to document this in a changelog file (even though functions are only in the internal namespace, users might nonetheless have used those explicitly). What do you think @bergbauer?

@bangerth
Copy link
Member

bangerth commented Mar 9, 2024

People should not be using things in internal namespaces. If people need to, then these functions should not be located in namespace internal.

@bergbauer
Copy link
Contributor

Oh i missed those, thanks for the fix @kronbichler ! I don't think anybody except the two of us uses these functions in user code so a changelog should be unnecessary 😅

@peterrum peterrum merged commit 1a4e7aa into dealii:master Mar 9, 2024
15 of 16 checks passed
@kronbichler kronbichler deleted the fix_tests-3 branch March 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression tester regressed f84052
5 participants