Tensor product kernels: specialize a function for complex numbers #16754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the code generated by compilers for the matrix-free tensor product kernels when used for complex numbers is rather poor, because it will not exploit fused multiply-add functions in the inner reduction loops and thus performs unnecessary work. This is easy to fix, especially with
if constexpr
facilities: We write the code in a way that lets the compiler straight-forwardly use FMA operations on both the real and imaginary part.