Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for COMSOL .mphtxt triangle meshes. #16804

Merged
merged 1 commit into from Apr 1, 2024
Merged

Add a test for COMSOL .mphtxt triangle meshes. #16804

merged 1 commit into from Apr 1, 2024

Conversation

bangerth
Copy link
Member

Related to a forum question. It turns out that we can already read these, but it's (always) useful to add another test.

drwells
drwells approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@drwells drwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - this is fine once we add the missing grid file (and run make indent)

tests/grid/grid_in_comsol_mphtxt_03.cc Outdated Show resolved Hide resolved
@bangerth
Copy link
Member Author

Yes, I forgot to add the input file... It's added now.

@masterleinad masterleinad merged commit 8fe0ab2 into dealii:master Apr 1, 2024
16 checks passed
@bangerth bangerth deleted the comsol-tri branch April 1, 2024 15:54
@tamiko tamiko mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@drwells drwells drwells approved these changes

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bangerth @masterleinad @drwells