Remove hardcoded inverse orientation #16806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
force-pushed
the
remove-hardcoded-inverse-orientation
branch
from
cd92f52
to
ac16344
Compare
bangerth
approved these changes
Mar 28, 2024
|
You'll have to fix the indentation issue. Otherwise good to go. |
This way we can call standard_to_real_face_vertex for all supported topological dimensions.
drwells
force-pushed
the
remove-hardcoded-inverse-orientation
branch
from
ac16344
to
41ff5a1
Compare
|
Thanks - fixed! |
|
It looks like the tpetra tester failed due to a race condition to create a folder in openmpi - I thought we fixed that? |
masterleinad
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14667. Followup to #16780.