Use ArrayView for interface to tensor-product point evaluator #16844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the changes are all in |
masterleinad
approved these changes
Apr 3, 2024
kronbichler
force-pushed
the
eval_interface
branch
from
9e5091c
to
8da0448
Compare
bangerth
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a follow-up PR, I would like to fix some internal operations in
MappingQ. For this, I need to change the interface forevaluate_tensor_product_xxxfromconst std::vector<Number>toArrayView<const Number>. I think this makes for a nicer interface overall in terms of application flexibility, but it requires me to change some of the users.