Fix a whole lot of typos. #16875
Merged
Fix a whole lot of typos. #16875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
reviewed
Apr 8, 2024
masterleinad
approved these changes
Apr 8, 2024
kronbichler
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Whenever I see these things fixed (thank you!), I cannot help but be amused by how funny many of them actually turn out to be. I certainly won't blame anyone (apart from myself maybe), but I think it just shows how much text we have if, despite all care and code review, some slip through.
drwells
approved these changes
Apr 8, 2024
bangerth
commented
Apr 8, 2024
| * Patterns::Tools::Convert<TupleTyple>::to_value(), where `TupleType` here is | ||
| * Patterns::Tools::Convert<TupleType>::to_value(), where `TupleType` here is |
There was a problem hiding this comment.
This was my favorite :-)
|
Yes, I agree. Some of them definitely made me chuckle. I think you can still see in some of the commentary the German roots of their authors, and their not-so-perfect command of the English language at the time :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used a tool that ASPECT has recently integrated into its CI check. It fins a lot of false positives (which I suspect we could address) plus a lot of actual issues that I'm fixing here.