Un-hardcode 2d orientation. #16884
Merged
Un-hardcode 2d orientation. #16884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For mixed meshes, we need to support quadrilaterals whose faces may have either valid line orientation.
This fails on master due to twisted elements.
drwells
force-pushed
the
un-hardcode-2d-orientation
branch
from
c024e21
to
362ca48
Compare
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More on #14667.
The last commit adds a test which aborts on
masterbut works correctly with this branch - it attains 4th-order accuracy on a mixed mesh with quadrilateral faces not in the standard orientation, P3, and Q3.