FEPointEvaluation: Implement n_active_entries_per_quadrature_batch #16891
Conversation
bergbauer
force-pushed
the
active_q_points
branch
from
ed6f0a2
to
812c3cd
Compare
| ExcMessage( | ||
| "Calling this function only makes sense in fully vectorized mode.")); | ||
| if (q == n_q_batches - 1) | ||
| return n_q_points_scalar & (n_lanes_user_interface - 1); |
There was a problem hiding this comment.
Is there a reason you change from the modulo operation to this form? In my experience, compilers reduce modulo (power of two) into bitwise and with (power of two - 1), and to me the modulo operation is more readable.
There was a problem hiding this comment.
We also use it here
dealii/include/deal.II/matrix_free/fe_point_evaluation.h
Lines 2833 to 2835 in 31a1263
I can change this to modulo if you prefer.
There was a problem hiding this comment.
I don't care too much, I was just wondering why you changed it. I think it is good to be consistent within the code base, and I believe the modulo is used more frequently as I see from a quick search (but it is hard to filter out other uses of &).
bergbauer
force-pushed
the
active_q_points
branch
from
812c3cd
to
778ce95
Compare
|
/rebuild |
This function allows to only loop over active lanes in a quadrature batch.
FYI @ritthaler