Import TaskFlow 3.7.0. #16892
Merged
Import TaskFlow 3.7.0. #16892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, exactly what I needed. |
|
I think this is relatively low risk to merge if we want to go this route. I also tracked down the issue that leads to the deadlocks, see the link in #15634. |
Closed
bangerth
changed the title
|
I updated this to the TaskFlow 3.7 release. This seems to be working with the commits in #15634, so I think we're finally making some progress here. I would appreciate if we could merge this here in the near future -- it's low risk because we're not using TaskFlow anyway at the moment, so whatever version we have in |
|
OK, this works with the exception of the offline OSX tester. Someone willing to hit the button? |
tjhei
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15610, we imported TaskFlow 3.6.0 but found that this leads to deadlocks when actually used (in #15634). This patch imports the current 3.7.0 (=development) branch of TaskFlow. Nothing actually uses this, but I thought it'd be useful to see whether we can't get things to actually work and it's not use for this to start with something we already know doesn't work (=3.6.0). We might as well start with their current version.
This patch builds correctly for me (using
-DDEAL_II_WITH_TASKFLOW=ONof course) and also passes the quick tests that have a taskflow test.