Revert "Export compile definitions for dependent targets"

[tamiko]

We have switched to adding target compile definitions to the interface targets recorded in cmake/deal.II/deal.IITargets.cmake.

Here, for the deal.II targets themselves and all external features we configure we record everything that is necessary to compile and link against deal.II successfully. On my system this looks as follows:

# Create imported target dealii::dealii_debug
add_library(dealii::dealii_debug SHARED IMPORTED)

set_target_properties(dealii::dealii_debug PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "DEBUG"
  INTERFACE_COMPILE_FEATURES "cxx_std_17"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "dealii::interface_lapack;dealii::interface_mpi;dealii::interface_tbb;dealii::interface_zlib;dealii::interface_boost;dealii::interface_ginkgo;dealii::interface_metis;dealii::interface_petsc;dealii::interface_trilinos;dealii::interface_umfpack;dealii::interface_kokkos;dealii::interface_adolc;dealii::interface_arborx;dealii::interface_arpack;dealii::interface_assimp;dealii::interface_cgal;dealii::interface_gmsh;dealii::interface_gsl;dealii::interface_hdf5;dealii::interface_muparser;dealii::interface_opencascade;dealii::interface_p4est;dealii::interface_scalapack;dealii::interface_slepc;dealii::interface_sundials;dealii::interface_symengine"
  INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "include"
)

# Create imported target dealii::dealii_release
add_library(dealii::dealii_release SHARED IMPORTED)

set_target_properties(dealii::dealii_release PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "NDEBUG"
  INTERFACE_COMPILE_FEATURES "cxx_std_17"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "dealii::interface_lapack;dealii::interface_mpi;dealii::interface_tbb;dealii::interface_zlib;dealii::interface_boost;dealii::interface_ginkgo;dealii::interface_metis;dealii::interface_petsc;dealii::interface_trilinos;dealii::interface_umfpack;dealii::interface_kokkos;dealii::interface_adolc;dealii::interface_arborx;dealii::interface_arpack;dealii::interface_assimp;dealii::interface_cgal;dealii::interface_gmsh;dealii::interface_gsl;dealii::interface_hdf5;dealii::interface_muparser;dealii::interface_opencascade;dealii::interface_p4est;dealii::interface_scalapack;dealii::interface_slepc;dealii::interface_sundials;dealii::interface_symengine"
  INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "include"
)

<snip>

set_target_properties(dealii::interface_trilinos PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "KOKKOS_DEPENDENCE"
  INTERFACE_INCLUDE_DIRECTORIES "/usr/include;/usr/include/trilinos;/usr/include/eigen3;/usr/include/scotch;/usr/include/blacs"
  INTERFACE_LINK_LIBRARIES "<snip>"
  INTERFACE_LINK_OPTIONS "-DKOKKOS_DEPENDENCE"
  INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "/usr/include;/usr/include/trilinos;/usr/include/eigen3;/usr/include/scotch;/usr/include/blacs"
)

<snip>

Now, when linking to deal.II with either the macro deal_ii_setup_target(), or with target_link_libraries(<target> dealii::dealii<|_debug|_release>)
CMake automatically constructs final compile and link options for the target:

/usr/lib/llvm/18/bin/clang++ -DKOKKOS_DEPENDENCE -DNDEBUG <includes> <compile flags> <warning flags> <...> -c .../examples/step-1/step-1.cc
/usr/lib/llvm/18/bin/clang++ <linker flags> -DKOKKOS_DEPENDENCE .../step-1.cc.o <libraries>

Reverified on my machine.

This reverts commit a29f491.

In reference to #16834

[gassmoeller]

I am ok reverting this. It just means I will have to re-check what prompted me to #16834.

[masterleinad]

I can confirm that the respective debug and release targets look good and, in particular, contain

INTERFACE_COMPILE_DEFINITIONS "DEBUG"

INTERFACE_COMPILE_DEFINITIONS "NDEBUG"

[gassmoeller]

Ok let's revert this for now. I will see if I can reproduce my original issue, but if it doesnt come up again this is not need.

[gassmoeller]

/rebuild

[tamiko]

@gassmoeller Again, apologies for not having spotted the PR earlier.