Remove extra orientation functions #16965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orientations are only ever set once (in create_triangulation()) and, in that context, are always encoded with the combined orientation.
bangerth
reviewed
May 6, 2024
masterleinad
approved these changes
May 6, 2024
drwells
force-pushed
the
remove-extra-orientation-functions
branch
from
d28f52d
to
a93f80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14667. Now that we have
if constexpr ()we can make a lot of this code simpler. We also never use theTriaObjectsOrientations::set_*()functions, so those can all go.