Provide an error message that is more meaningful for global MG transfer operator. #17036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
commented
May 17, 2024
Comment on lines
+1448
to
1457
| Assert( | ||
| cell_fine->child(0)->is_active(), | ||
| ExcMessage( | ||
| "In building a transfer operator, we are " | ||
| "expecting that a cell is not or at most once refined " | ||
| "on the other multigrid level. But it is refined more than once. " | ||
| "Are you trying to build a transfer operator across " | ||
| "more than one level of mesh refinement?")); | ||
| if (cell_fine->child(0)->subdomain_id() != | ||
| cell->subdomain_id()) |
There was a problem hiding this comment.
I am here implicitly assuming that the whole MG global coarsening transfer operator approach is indeed only meant if the two meshes differ by at most one level of refinement. Please correct me if that is not correct.
kronbichler
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my students, @jerett-cc, was trying to use the new across-mesh interpolate function from #16734 to build a transfer operator across more than one mesh refinement. This failed with a non-informative message, see jerett-cc/ryujin#30. This patch adds an assertion that ensures that we're not calling
cell->subdomain_id()if the cell is not actually active, and give a useful error message for the case where the condition is violated.