Add erfc function to FunctionParser. #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks good. Would you mind adding a small test case for this feature? It would make sense to create a test If you have not set up deal.II tests yet, you find the basic information here: https://www.dealii.org/developer/developers/testsuite.html |
|
ping @jperryhouts ? |
|
Oh, sorry. I'll add the test this weekend if I have a chance. Monday afternoon at the latest. Thanks! |
|
OK, I think this is ready to go. Sorry for the delay. |
|
Great, thanks! |
kronbichler
added a commit
that referenced
this pull request
Nov 3, 2015
Add erfc function to FunctionParser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It came up in an Aspect model earlier that it would be useful to have erfc available to the FunctionParser. I don't know of a more modular way to do it than to add it to the builtin functions.