CMake: Simplify run_test.sh and avoid array handling magic #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
commented
Jan 12, 2017
| for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; | ||
| done | ||
| echo " " | ||
| } |
There was a problem hiding this comment.
@tjhei Simply restructuring the shell script and removing this arcane magic is also an option.
tjhei
reviewed
Jan 12, 2017
| # same. Create a diff file "diff${variant}" for each variant file that | ||
| # is found (including the main comparison file). | ||
| # Pick up main comparison file and all variants. A valid variant name is | ||
| # of the form [...].output.[STRING] |
There was a problem hiding this comment.
You don't enforce the "." after output though, right?
There was a problem hiding this comment.
No, I probably don't enforce it. Judging from the snippet below, we pick up everything that matches "${COMPARISON_FILE}"*.
There was a problem hiding this comment.
Now, I also remember the reason. The old variant was
for files in "${COMPARISON_FILE}" "${COMPARISON_FILE}".*; ...
This produces at least a warning if the second expression doesn't match anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #3775