Use check_solver_within_range in PETSc(serial) tests #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
usecheck_solver_petsc
branch
from
188a177
to
67f86e9
Compare
|
/run-tests |
tjhei
approved these changes
Aug 8, 2017
|
I would still prefer that we are a bit more conservative and add a new macro that reproduces the current test output. |
|
@drwells I disagree. The idea is to make the output more stable with respect to compiler optimizations. |
|
I'll need to fix up this a bit. |
masterleinad
force-pushed
the
usecheck_solver_petsc
branch
from
67f86e9
to
d452753
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4715. Relates #4704.