New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadWriteVector and TrilinosWrappers::MPI::Vector print in parallel #5014
Conversation
Print index and value for ::print() of ReadWriteVector and TrilinosWrappers::MPI::Vector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge if the answer to my question is that you don't have to worry about 32 vs 64 bit issues.
source/lac/trilinos_vector.cc
Outdated
{ | ||
auto global_id = [&] (const size_type index) | ||
{ | ||
return vector->Map().GID(static_cast<TrilinosWrappers::types::int_type>(index)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice use of a lambda!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to distinguish between GID
and GID64
in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you probably want to use this function https://github.com/dealii/dealii/blob/master/include/deal.II/lac/trilinos_vector.h#L191
fixed. Thanks for the hint, @Rombur |
OK to merge once the tester is happy. /run-tests |
test failure is unrelated:
|
Print index and value for ::print() of ReadWriteVector and
TrilinosWrappers::MPI::Vector.