Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadWriteVector and TrilinosWrappers::MPI::Vector print in parallel #5014

Merged
merged 3 commits into from Sep 5, 2017

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Sep 3, 2017

Print index and value for ::print() of ReadWriteVector and
TrilinosWrappers::MPI::Vector.

Print index and value for ::print() of ReadWriteVector and
TrilinosWrappers::MPI::Vector.
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if the answer to my question is that you don't have to worry about 32 vs 64 bit issues.

{
auto global_id = [&] (const size_type index)
{
return vector->Map().GID(static_cast<TrilinosWrappers::types::int_type>(index));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice use of a lambda!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to distinguish between GID and GID64 in this context?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjhei
Copy link
Member Author

tjhei commented Sep 5, 2017

fixed. Thanks for the hint, @Rombur

@bangerth
Copy link
Member

bangerth commented Sep 5, 2017

OK to merge once the tester is happy.

/run-tests

@tjhei
Copy link
Member Author

tjhei commented Sep 5, 2017

test failure is unrelated:

/tests/fe/interpolate_system_2.cc:36:28: error: use of deleted function ‘dealii::FESystem<dim, spacedim>::FESystem(const dealii::FESystem<dim, spacedim>&) [with int dim = 2; int spacedim = 2]’

@bangerth bangerth merged commit 8132849 into dealii:master Sep 5, 2017
@tjhei tjhei deleted the parallel_vec_print branch September 5, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants