Fix mapping cartesian update inverse jacobian #5313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, nobody tried to compute the inverse jacobian for a
MappingCartesian
at least since 2015. This bug now comes up, becauseVectorTools::interpolate
since a recent pull request does this for every mapping. This PR fixes a part of geodynamics/aspect#1936, namely the following error:The other errors in geodynamics/aspect#1936 seem to be caused by a different issue, I will keep looking for those.